diff --git a/src/main/java/com/palnet/biz/api/bas/flight/service/BasFlightService.java b/src/main/java/com/palnet/biz/api/bas/flight/service/BasFlightService.java index 72543f7..30c0e9e 100644 --- a/src/main/java/com/palnet/biz/api/bas/flight/service/BasFlightService.java +++ b/src/main/java/com/palnet/biz/api/bas/flight/service/BasFlightService.java @@ -672,7 +672,7 @@ public class BasFlightService { return readBody(con.getErrorStream()); } } catch (IOException e) { - throw new RuntimeException("API 요청과 응답 실패", e); + throw new RuntimeException("API Request and Response Fail", e); } finally { con.disconnect(); } @@ -683,9 +683,9 @@ public class BasFlightService { URL url = new URL(apiUrl); return (HttpURLConnection)url.openConnection(); } catch (MalformedURLException e) { - throw new RuntimeException("API URL이 잘못되었습니다. : " + apiUrl, e); + throw new RuntimeException("Invalid API URL. : " + apiUrl, e); } catch (IOException e) { - throw new RuntimeException("연결이 실패했습니다. : " + apiUrl, e); + throw new RuntimeException("Connection Fail. : " + apiUrl, e); } } @@ -695,14 +695,15 @@ public class BasFlightService { try(BufferedReader lineReader = new BufferedReader(streamReader)) { StringBuilder responseBody = new StringBuilder(); - String line; - while ((line = lineReader.readLine()) != null) { + String line = lineReader.readLine(); + while (line != null) { responseBody.append(line); + line = lineReader.readLine(); } return responseBody.toString(); } catch (IOException e) { - throw new RuntimeException("API 응답을 읽는데 실패했습니다.", e); + throw new RuntimeException("Fail to read API Response", e); } } @@ -734,10 +735,11 @@ public class BasFlightService { rd = new BufferedReader(new InputStreamReader(conn.getErrorStream())); } StringBuilder sb = new StringBuilder(); - String line; + String line = rd.readLine(); - while ((line = rd.readLine()) != null) { + while (line != null) { sb.append(line); + line = rd.readLine(); } CtrTrnsLctnModel weatherResult = ctrTrnsLctnService.convertLatlonToAddress(rq.getNx2(),rq.getNy2()); diff --git a/src/main/java/com/palnet/biz/api/ctr/cntrl/service/CtrCntrlService.java b/src/main/java/com/palnet/biz/api/ctr/cntrl/service/CtrCntrlService.java index 0c8bb31..23e05ff 100644 --- a/src/main/java/com/palnet/biz/api/ctr/cntrl/service/CtrCntrlService.java +++ b/src/main/java/com/palnet/biz/api/ctr/cntrl/service/CtrCntrlService.java @@ -717,9 +717,10 @@ public class CtrCntrlService { rd = new BufferedReader(new InputStreamReader(conn.getErrorStream())); } StringBuilder sb = new StringBuilder(); - String line; - while ((line = rd.readLine()) != null) { + String line = rd.readLine(); + while (line != null) { sb.append(line); + line = rd.readLine(); } CtrTrnsLctnModel weatherResult = ctrTrnsLctnService.convertLatlonToAddress(rq.getNx(),rq.getNy()); log.info("weatherResult >>>> : {}", weatherResult); diff --git a/src/main/java/com/palnet/comn/utils/HttpUtils.java b/src/main/java/com/palnet/comn/utils/HttpUtils.java index e7e1a45..638b043 100644 --- a/src/main/java/com/palnet/comn/utils/HttpUtils.java +++ b/src/main/java/com/palnet/comn/utils/HttpUtils.java @@ -57,10 +57,10 @@ public class HttpUtils { response.setHeader ("Content-Length", ""+file.length() ); outStream = response.getOutputStream(); byte b[] = new byte[(int)file.length()]; - int leng = 0; - - while( (leng = inputStream.read(b)) > 0 ){ + int leng = inputStream.read(b); + while(leng > 0 ){ outStream.write(b,0,leng); + leng = inputStream.read(b); } } catch (Exception e) { @@ -182,9 +182,10 @@ public class HttpUtils { if (respCd == HttpStatus.SC_OK) { br = new BufferedReader(new InputStreamReader(method.getResponseBodyAsStream())); - String readLine; - while (((readLine = br.readLine()) != null)) { + String readLine = br.readLine(); + while (readLine != null) { log.info(readLine); + readLine = br.readLine(); } } else { log.error("respCd: {}", respCd);